Skip to content

Add ExponentialWeighted primitives and DateToTimeZone primitive #2318

Merged
gsheni merged 11 commits into
mainfrom
add_ts_primitives
Oct 12, 2022
Merged

Add ExponentialWeighted primitives and DateToTimeZone primitive #2318
gsheni merged 11 commits into
mainfrom
add_ts_primitives

Conversation

@gsheni
Copy link
Copy Markdown
Contributor

@gsheni gsheni commented Oct 6, 2022

No description provided.

@gsheni gsheni requested a review from sbadithe October 6, 2022 19:43
@gsheni gsheni self-assigned this Oct 6, 2022
@gsheni gsheni marked this pull request as ready for review October 6, 2022 19:45
Comment thread featuretools/primitives/standard/datetime_transform_primitives.py
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 7, 2022

Codecov Report

Merging #2318 (f9b5940) into main (7f3a3a8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main    #2318    +/-   ##
========================================
  Coverage   99.37%   99.38%            
========================================
  Files         145      147     +2     
  Lines       17682    17895   +213     
========================================
+ Hits        17572    17785   +213     
  Misses        110      110            
Impacted Files Coverage Δ
...rimitives/standard/rolling_transform_primitives.py 100.00% <ø> (ø)
featuretools/primitives/standard/api.py 100.00% <100.00%> (ø)
...imitives/standard/datetime_transform_primitives.py 100.00% <100.00%> (ø)
...tives/standard/exponential_transform_primitives.py 100.00% <100.00%> (ø)
...etools/tests/entityset_tests/test_serialization.py 99.68% <100.00%> (+<0.01%) ⬆️
...sts/primitive_tests/test_exponential_primitives.py 100.00% <100.00%> (ø)
...ests/primitive_tests/test_feature_serialization.py 99.61% <100.00%> (+<0.01%) ⬆️
.../tests/primitive_tests/test_transform_primitive.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

primitive_instance = ExponentialWeightedAverage(com=0.5)
primitive_func = primitive_instance.get_function()
array = pd.Series([1, 2, 7, 5])
answer = pd.Series(primitive_func(array))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but we could also do actual vs expected

@gsheni gsheni merged commit 9bf1b18 into main Oct 12, 2022
@gsheni gsheni deleted the add_ts_primitives branch October 12, 2022 14:22
@sbadithe sbadithe mentioned this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants