Restructure primitives directory to use individual primitives files

[thehomebrewnerd]

Restructure primitives directory to use individual primitives files

Closes #2179

[codecov]

Codecov Report

Merging #2331 (edb22fd) into main (a781c6f) will increase coverage by 0.01%.
The diff coverage is 99.95%.

@@            Coverage Diff             @@
##             main    #2331      +/-   ##
==========================================
+ Coverage   99.39%   99.41%   +0.01%     
==========================================
  Files         179      310     +131     
  Lines       19166    19798     +632     
==========================================
+ Hits        19051    19683     +632     
  Misses        115      115              

Impacted Files	Coverage Δ
...s/standard/transform/natural_language/constants.py	100.00% <ø> (ø)
...tandard/transform/natural_language/count_string.py	100.00% <ø> (ø)
...sform/natural_language/mean_characters_per_word.py	100.00% <ø> (ø)
...d/transform/natural_language/median_word_length.py	100.00% <ø> (ø)
...ransform/natural_language/num_unique_separators.py	100.00% <ø> (ø)
...ansform/natural_language/number_of_unique_words.py	100.00% <ø> (ø)
...form/natural_language/number_of_words_in_quotes.py	100.00% <ø> (ø)
...rd/transform/natural_language/total_word_length.py	100.00% <ø> (ø)
...primitives/standard/transform/time_series/utils.py	100.00% <ø> (ø)
...utational_backend/test_calculate_feature_matrix.py	100.00% <ø> (ø)
... and 163 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[sbadithe]

Is it possible that we could run into issues with file handling and/or imports if the filename shares its name with a Python built-in? i.e. max.py and max.

[thehomebrewnerd]

Is it possible that we could run into issues with file handling and/or imports if the filename shares its name with a Python built-in? i.e. max.py and max.

That was a problem with and and or, and that's why I appended _primitive to the filenames, but I don't think there is an issue with max...if there is, I didn't run into it.

[ozzieD]

These can all be relative imports

[thehomebrewnerd]

We have a pre-commit hook that converts them all to absolute.

[ozzieD]

shucks, no worries.

[ozzieD]

I'm pretty sure this line can be deleted in every init.py file. I added an ignore to these files in .flake8

[thehomebrewnerd]

We can't delete it in the files that use the from ... import * approach or we get this linting error:

featuretools/primitives/standard/__init__.py:4:1: F403 'from featuretools.primitives.standard.transform_primitives import *' used; unable to detect undefined names

I was able to remove it from a couple other places though.

[sbadithe]

Is it possible that we could run into issues with file handling and/or imports if the filename shares its name with a Python built-in? i.e. max.py and max.

That was a problem with and and or, and that's why I appended _primitive to the filenames, but I don't think there is an issue with max...if there is, I didn't run into it.

I think it might be good to treat all, any, max, min, and sum the same way to prevent any potential naming issues in the future.

[ozzieD]

Since we have better namespacing we can rename rolling_primitives_utils.py to utils.py

[thehomebrewnerd]

Since we have better namespacing we can rename rolling_primitives_utils.py to utils.py

Done!

[thehomebrewnerd]

I think it might be good to treat all, any, max, min, and sum the same way to prevent any potential naming issues in the future.

@sbadithe I renamed all the associated files to include the _primitive suffix.

[rwedge]

Thoughts on shortening the primitive submodules a bit?

Going from

featuretools.primitives.standard.transform_primitives.binary_transform_primitives

to

featuretools.primitives.standard.transform.binary

Not as descriptive but transform and primitive are still in the submodule path

[thehomebrewnerd]

Thoughts on shortening the primitive submodules a bit?

Going from

featuretools.primitives.standard.transform_primitives.binary_transform_primitives

to

featuretools.primitives.standard.transform.binary

Not as descriptive but transform and primitive are still in the submodule path

@rwedge Not opposed to it. Would help make some of the imports more manageable and not split over so many lines I think.

[sbadithe]

I like that num_characters and num_words are moved here

[ozzieD]

I'm wondering if we can put all the stray transform primitives in their own folders as well. I'm okay with this as is. But maybe we could but the email and url ones in thier respective folders. Maybe the Cosine, Tangent, Percentile etc.. in one called math.