Skip to content

Add Expanding Primitives #2343

Merged
sbadithe merged 81 commits intomainfrom
Add-Expanding-Primitives
Nov 28, 2022
Merged

Add Expanding Primitives #2343
sbadithe merged 81 commits intomainfrom
Add-Expanding-Primitives

Conversation

@sbadithe
Copy link
Contributor

@sbadithe sbadithe self-assigned this Oct 28, 2022
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #2343 (4f90e75) into main (e308921) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main    #2343    +/-   ##
========================================
  Coverage   99.49%   99.49%            
========================================
  Files         310      318     +8     
  Lines       19821    20033   +212     
========================================
+ Hits        19720    19932   +212     
  Misses        101      101            
Impacted Files Coverage Δ
...mitives/standard/transform/time_series/__init__.py 100.00% <100.00%> (ø)
...andard/transform/time_series/expanding/__init__.py 100.00% <100.00%> (ø)
...transform/time_series/expanding/expanding_count.py 100.00% <100.00%> (ø)
...d/transform/time_series/expanding/expanding_max.py 100.00% <100.00%> (ø)
.../transform/time_series/expanding/expanding_mean.py 100.00% <100.00%> (ø)
...d/transform/time_series/expanding/expanding_min.py 100.00% <100.00%> (ø)
...d/transform/time_series/expanding/expanding_std.py 100.00% <100.00%> (ø)
...transform/time_series/expanding/expanding_trend.py 100.00% <100.00%> (ø)
...primitives/standard/transform/time_series/utils.py 100.00% <100.00%> (ø)
featuretools/tests/conftest.py 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbadithe
Copy link
Contributor Author

sbadithe commented Nov 10, 2022

To summarize current changes regarding return LogicalType:

Trend, Standard Dev: Double
Count, Max, Mean, Min: No LogicalType specified

@thehomebrewnerd
Copy link
Contributor

thehomebrewnerd commented Nov 10, 2022

To summarize current changes regarding return LogicalType:

Trend, Standard Dev: Double Count, Max, Mean, Min: No LogicalType specified

I think it should be this:
Mean, Trend, STD: Double (highly unlikely that any of these will return all whole numbers)
Count: IntegerNullable (count will always be a whole number)
Max, Min: No logical type (min/max could be float or int depending on type of input data)

@sbadithe
Copy link
Contributor Author

To summarize current changes regarding return LogicalType:
Trend, Standard Dev: Double Count, Max, Mean, Min: No LogicalType specified

I think it should be this: Mean, Trend, STD: Double (highly unlikely that any of these will return all whole numbers) Count: IntegerNullable (count will always be a whole number) Max, Min: No logical type (min/max could be float or int depending on type of input data)

Sorry about that. This makes sense to me

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small comments, but otherwise this is looking pretty good to me.

@sbadithe sbadithe merged commit dbed9ba into main Nov 28, 2022
@sbadithe sbadithe deleted the Add-Expanding-Primitives branch November 28, 2022 20:56
@thehomebrewnerd thehomebrewnerd mentioned this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Expanding* primitives for time series feature engineering

3 participants