Conversation
sbadithe
commented
Oct 28, 2022
- Fixes Add Expanding* primitives for time series feature engineering #2242
Codecov Report
@@ Coverage Diff @@
## main #2343 +/- ##
========================================
Coverage 99.49% 99.49%
========================================
Files 310 318 +8
Lines 19821 20033 +212
========================================
+ Hits 19720 19932 +212
Misses 101 101
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…/featuretools into Add-Expanding-Primitives
…/featuretools into Add-Expanding-Primitives
|
To summarize current changes regarding return LogicalType: Trend, Standard Dev: Double |
I think it should be this: |
Sorry about that. This makes sense to me |
…dd-Expanding-Primitives
featuretools/tests/primitive_tests/test_expanding_primitives.py
Outdated
Show resolved
Hide resolved
featuretools/tests/primitive_tests/test_expanding_primitives.py
Outdated
Show resolved
Hide resolved
thehomebrewnerd
left a comment
There was a problem hiding this comment.
Just a couple small comments, but otherwise this is looking pretty good to me.