Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tmpdir fixture with tmp_path #2344

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Oct 28, 2022

Fixes #2151

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #2344 (eedc610) into main (9d8c8f3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2344   +/-   ##
=======================================
  Coverage   99.41%   99.42%           
=======================================
  Files         310      310           
  Lines       19798    19773   -25     
=======================================
- Hits        19683    19660   -23     
+ Misses        115      113    -2     
Impacted Files Coverage Δ
...utational_backend/test_calculate_feature_matrix.py 100.00% <100.00%> (ø)
featuretools/tests/conftest.py 100.00% <100.00%> (ø)
...eaturetools/tests/entityset_tests/test_plotting.py 100.00% <100.00%> (ø)
...etools/tests/entityset_tests/test_serialization.py 100.00% <100.00%> (+0.31%) ⬆️
...tests/primitive_tests/test_feature_descriptions.py 100.00% <100.00%> (ø)
...ests/primitive_tests/test_feature_serialization.py 100.00% <100.00%> (+0.38%) ⬆️
...s/tests/primitive_tests/test_feature_visualizer.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rwedge rwedge force-pushed the 2152-replace-pytest-tmpdir-with-tmp-path branch from 1f72381 to 827661e Compare October 31, 2022 17:46
@rwedge rwedge force-pushed the 2152-replace-pytest-tmpdir-with-tmp-path branch from 827661e to eedc610 Compare October 31, 2022 19:28
@rwedge rwedge marked this pull request as ready for review October 31, 2022 19:58
@rwedge rwedge merged commit cfa19d1 into main Oct 31, 2022
@rwedge rwedge deleted the 2152-replace-pytest-tmpdir-with-tmp-path branch October 31, 2022 20:43
@gsheni gsheni mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace tmpdir fixtures with tmp_path fixtures
2 participants