Conversation
rwedge
reviewed
Nov 3, 2022
Contributor
rwedge
left a comment
rwedge
left a comment
There was a problem hiding this comment.
featuretools/tests/cli_tests folder should be deleted
rwedge
reviewed
Nov 3, 2022
Contributor
rwedge
left a comment
rwedge
left a comment
There was a problem hiding this comment.
featuretools/utils/cli_utils.py should probably renamed (info_utils.py ?). And show_info should just turn into the print_info code
Codecov Report
@@ Coverage Diff @@
## main #2353 +/- ##
==========================================
+ Coverage 99.42% 99.48% +0.05%
==========================================
Files 311 309 -2
Lines 19814 19771 -43
==========================================
- Hits 19701 19670 -31
+ Misses 113 101 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gsheni
commented
Nov 3, 2022
| "myst-parser == 0.18.0", | ||
| "nlp_primitives >= 2.3.0", | ||
| "autonormalize >= 2.0.1", | ||
| "click >=7.0.0", |
Contributor
Author
There was a problem hiding this comment.
rwedge
reviewed
Nov 3, 2022
rwedge
reviewed
Nov 3, 2022
Contributor
rwedge
left a comment
rwedge
left a comment
There was a problem hiding this comment.
We should remove the CLI entry in pyproject.toml
[project.scripts]
featuretools = "featuretools.__main__:cli"
rwedge
reviewed
Nov 3, 2022
added 2 commits
November 3, 2022 15:57
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.