Skip to content

Remove click and associated CLI functions #2353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 3, 2022
Merged

Remove click and associated CLI functions #2353

merged 16 commits into from
Nov 3, 2022

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Nov 3, 2022 •
edited
Loading

@gsheni gsheni self-assigned this Nov 3, 2022
@gsheni gsheni marked this pull request as ready for review November 3, 2022 14:44
rwedge
rwedge reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

featuretools/tests/cli_tests folder should be deleted

rwedge
rwedge reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

featuretools/utils/cli_utils.py should probably renamed (info_utils.py ?). And show_info should just turn into the print_info code

@codecov
Copy link

codecov bot commented Nov 3, 2022 •
edited
Loading

Codecov Report

Merging #2353 (cf33598) into main (93eaa58) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2353      +/-   ##
==========================================
+ Coverage   99.42%   99.48%   +0.05%     
==========================================
  Files         311      309       -2     
  Lines       19814    19771      -43     
==========================================
- Hits        19701    19670      -31     
+ Misses        113      101      -12
Impacted Files Coverage Δ
featuretools/utils/utils_info.py 95.45% <ø> (ø)
featuretools/tests/utils_tests/test_utils_info.py 100.00% <100.00%> (ø)
featuretools/utils/api.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gsheni
gsheni commented Nov 3, 2022
View reviewed changes
pyproject.toml
@@ -108,6 +108,7 @@ docs = [
"myst-parser == 0.18.0",
"nlp_primitives >= 2.3.0",
"autonormalize >= 2.0.1",
"click >=7.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need for https://github.com/alteryx/featuretools/blob/main/docs/notebook_version_standardizer.py

@gsheni gsheni enabled auto-merge (squash) November 3, 2022 15:53
@gsheni gsheni disabled auto-merge November 3, 2022 15:53
rwedge
rwedge reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the CLI entry in pyproject.toml

[project.scripts]
featuretools = "featuretools.__main__:cli"

@gsheni gsheni requested a review from rwedge November 3, 2022 17:11
Gaurav Sheni added 2 commits November 3, 2022 15:57
rwedge
rwedge approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsheni gsheni merged commit 5f61790 into main Nov 3, 2022
@gsheni gsheni deleted the remove_click branch November 3, 2022 20:29
@gsheni gsheni mentioned this pull request Nov 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

@thehomebrewnerd thehomebrewnerd Awaiting requested review from thehomebrewnerd

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove click and its associated functions
2 participants
@gsheni @rwedge