-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid stacking "expanding" primitives #238
Conversation
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
+ Coverage 93.64% 93.65% +0.01%
==========================================
Files 71 71
Lines 7690 7697 +7
==========================================
+ Hits 7201 7209 +8
+ Misses 489 488 -1
Continue to review full report at Codecov.
|
if primitive.expanding: | ||
return False | ||
for f in input_types: | ||
if f.expanding: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can move this check inside of the loop a couple lines down where we also loop over each input.
also, let's add a test case for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on the test case.
For moving this inside the for
loop, want me to also move the check for base_of_exclude
which can also be placed inside the larger loop?
Looks good. Merging |
This PR prevents DFS from trying to stack on primitives which output "expanding" features. It is resolves the error from #85.