Fix base_of_exclude handling
#2380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2380 +/- ##
=======================================
Coverage 99.49% 99.50%
=======================================
Files 322 322
Lines 20106 20146 +40
=======================================
+ Hits 20005 20046 +41
+ Misses 101 100 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sbadithe
commented
Nov 30, 2022
| if not primitive_stack_on_self and isinstance(f_primitive, primitive_class): | ||
| return False | ||
|
|
||
| if isinstance(f_primitive, tup_primitive_stack_on_exclude): | ||
| return False | ||
|
|
||
| # R TODO: handle this |
There was a problem hiding this comment.
After discussing with @rwedge, determined that this todo was already completed
rwedge
reviewed
Dec 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base_of_excludehandling #2323check_stackingfunction is only called during the generation of aggregation features. This means that features such asbase_of_excludeandstack_on_excludedo not work when creating transform features. This PR addresses that bug. It also does some refactoring by moving thestack_on_excludeattribute and related member data off of AggregationPrimitiveBase and onto PrimitiveBase, seeing as the functionality provided does not need to be unique to AggregationPrimitives.