Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use packaging library to compare versions in test_holiday_out_of_range #2382

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

thehomebrewnerd
Copy link
Contributor

Update test_holiday_out_of_range to use packaging to compare version numbers instead of trying to directly convert version number to float.

@thehomebrewnerd thehomebrewnerd requested review from rwedge and a team and removed request for rwedge November 28, 2022 17:13
@thehomebrewnerd thehomebrewnerd enabled auto-merge (squash) November 28, 2022 17:13
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #2382 (2b291e2) into main (01cb044) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2382   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files         310      310           
  Lines       19820    19821    +1     
=======================================
+ Hits        19719    19720    +1     
  Misses        101      101           
Impacted Files Coverage Δ
...rimitive_tests/test_distancetoholiday_primitive.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@thehomebrewnerd thehomebrewnerd merged commit 5ce6929 into main Nov 28, 2022
@thehomebrewnerd thehomebrewnerd deleted the holidays-fix branch November 28, 2022 17:26
@thehomebrewnerd thehomebrewnerd mentioned this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants