Use packaging library to compare versions in test_holiday_out_of_range#2382
Merged
Conversation
thehomebrewnerd
requested review from
a team and
rwedge
and removed request for
rwedge
Codecov Report
@@ Coverage Diff @@
## main #2382 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 310 310
Lines 19820 19821 +1
=======================================
+ Hits 19719 19720 +1
Misses 101 101
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sbadithe
approved these changes
Nov 28, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
test_holiday_out_of_rangeto use packaging to compare version numbers instead of trying to directly convert version number to float.