Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra calls to all, .values(), and .keys() when constructing ignore_columns in DeepFeatureSynthesis #2397

Merged
merged 10 commits into from
Dec 13, 2022

Conversation

sbadithe
Copy link
Contributor

  • In the init method for DeepFeatureSynthesis, we perform a type check on ignore_columns to make sure it maps strings to list of strings
  • Currently, we iterate multiple times over the input to perform this type checking, then iterate again to create the ignore_columns data structure.
  • By refactoring, we can reduce this to iterating once over the input. This reduces code complexity and computation required

@sbadithe sbadithe marked this pull request as ready for review December 10, 2022 01:21
@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #2397 (c5b757c) into main (9ce731e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2397   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files         326      326           
  Lines       20205    20208    +3     
=======================================
+ Hits        20093    20096    +3     
  Misses        112      112           
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 99.77% <100.00%> (+<0.01%) ⬆️
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.36% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbadithe sbadithe force-pushed the simplify-ignore-columns-checking branch from 8f1b2ae to 9fde2e1 Compare December 12, 2022 23:39
@sbadithe sbadithe force-pushed the simplify-ignore-columns-checking branch from 9fde2e1 to f618bb6 Compare December 12, 2022 23:40
@sbadithe sbadithe changed the title Remove excess calls to all, .values(), and .keys() when constructing ignore_columns in DeepFeatureSynthesis Remove extra calls to all, .values(), and .keys() when constructing ignore_columns in DeepFeatureSynthesis Dec 13, 2022
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbadithe sbadithe merged commit a0357c9 into main Dec 13, 2022
@sbadithe sbadithe deleted the simplify-ignore-columns-checking branch December 13, 2022 18:51
@thehomebrewnerd thehomebrewnerd mentioned this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants