-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra calls to all
, .values()
, and .keys()
when constructing ignore_columns
in DeepFeatureSynthesis
#2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2397 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 326 326
Lines 20205 20208 +3
=======================================
+ Hits 20093 20096 +3
Misses 112 112
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sbadithe
commented
Dec 10, 2022
ozzieD
approved these changes
Dec 12, 2022
sbadithe
force-pushed
the
simplify-ignore-columns-checking
branch
from
December 12, 2022 23:39
8f1b2ae
to
9fde2e1
Compare
sbadithe
force-pushed
the
simplify-ignore-columns-checking
branch
from
December 12, 2022 23:40
9fde2e1
to
f618bb6
Compare
sbadithe
changed the title
Remove excess calls to
Remove extra calls to Dec 13, 2022
all
, .values()
, and .keys()
when constructing ignore_columns
in DeepFeatureSynthesis
all
, .values()
, and .keys()
when constructing ignore_columns
in DeepFeatureSynthesis
rwedge
reviewed
Dec 13, 2022
rwedge
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init
method forDeepFeatureSynthesis
, we perform a type check onignore_columns
to make sure it maps strings to list of stringsignore_columns
data structure.