Add a get_recommend_primitives function for a single table EntitySet#2398
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2398 +/- ##
========================================
Coverage 99.40% 99.41%
========================================
Files 341 343 +2
Lines 20890 21056 +166
========================================
+ Hits 20766 20932 +166
Misses 124 124
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rwedge
reviewed
Dec 12, 2022
sbadithe
reviewed
Dec 12, 2022
sbadithe
reviewed
Dec 12, 2022
ozzieD
changed the title
sbadithe
reviewed
Dec 14, 2022
gsheni
changed the title
gsheni
requested review from
dvreed77,
rwedge,
sbadithe,
tamargrey and
thehomebrewnerd
sbadithe
reviewed
Jan 12, 2023
sbadithe
reviewed
Jan 12, 2023
sbadithe
reviewed
Jan 12, 2023
sbadithe
reviewed
Jan 12, 2023
sbadithe
reviewed
Jan 12, 2023
Co-authored-by: Shripad Badithe <60528327+sbadithe@users.noreply.github.com>
sbadithe
reviewed
Jan 12, 2023
sbadithe
reviewed
Jan 12, 2023
Co-authored-by: Shripad Badithe <60528327+sbadithe@users.noreply.github.com>
Co-authored-by: Shripad Badithe <60528327+sbadithe@users.noreply.github.com>
sbadithe
reviewed
Jan 12, 2023
thehomebrewnerd
left a comment
thehomebrewnerd
left a comment
Contributor
There was a problem hiding this comment.
Just a few relatively minor things, but generally looking pretty good to me.
Co-authored-by: Nate Parsons <4307001+thehomebrewnerd@users.noreply.github.com>
thehomebrewnerd
approved these changes
Jan 17, 2023
gsheni
reviewed
Jan 17, 2023
rwedge
reviewed
Jan 18, 2023
| pass | ||
| except Exception as e: # If error in calculating feature matrix pass on the recommendation | ||
| logger = logging.getLogger("featuretools") | ||
| logger.error(f"Exception in {f.primitive.name}: {str(e)}") |
Contributor
There was a problem hiding this comment.
What about a message like this?
"Exception with feature {f.get_name()} with primitive {f.primitive.name}: {str(e)}"
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_recommend_primitivesfunction which given a single table entity set, provides a list of recommended primitives.