-
Notifications
You must be signed in to change notification settings - Fork 897
Add a get_recommend_primitives function for a single table EntitySet #2398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2398 +/- ##
========================================
Coverage 99.40% 99.41%
========================================
Files 341 343 +2
Lines 20890 21056 +166
========================================
+ Hits 20766 20932 +166
Misses 124 124
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Shripad Badithe <60528327+sbadithe@users.noreply.github.com>
Co-authored-by: Shripad Badithe <60528327+sbadithe@users.noreply.github.com>
Co-authored-by: Shripad Badithe <60528327+sbadithe@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few relatively minor things, but generally looking pretty good to me.
Co-authored-by: Nate Parsons <4307001+thehomebrewnerd@users.noreply.github.com>
pass | ||
except Exception as e: # If error in calculating feature matrix pass on the recommendation | ||
logger = logging.getLogger("featuretools") | ||
logger.error(f"Exception in {f.primitive.name}: {str(e)}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about a message like this?
"Exception with feature {f.get_name()} with primitive {f.primitive.name}: {str(e)}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
get_recommend_primitives
function which given a single table entity set, provides a list of recommended primitives.