Skip to content

Add a get_recommend_primitives function for a single table EntitySet #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jan 18, 2023

Conversation

ozzieD
Copy link
Contributor

@ozzieD ozzieD commented Dec 12, 2022

  • Add a get_recommend_primitives function which given a single table entity set, provides a list of recommended primitives.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #2398 (45f8f46) into main (3607680) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main    #2398    +/-   ##
========================================
  Coverage   99.40%   99.41%            
========================================
  Files         341      343     +2     
  Lines       20890    21056   +166     
========================================
+ Hits        20766    20932   +166     
  Misses        124      124            
Impacted Files Coverage Δ
featuretools/__init__.py 72.72% <100.00%> (+0.63%) ⬆️
...ols/tests/utils_tests/test_recommend_primitives.py 100.00% <100.00%> (ø)
featuretools/utils/recommend_primitives.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ozzieD ozzieD changed the title Draft: add get_recommend_primitives add get_recommend_primitives Dec 14, 2022
@gsheni gsheni changed the title add get_recommend_primitives Add a get_recommend_primitives function for a single table EntitySet Dec 20, 2022
Co-authored-by: Shripad Badithe <60528327+sbadithe@users.noreply.github.com>
ozzieD and others added 2 commits January 12, 2023 14:48
Co-authored-by: Shripad Badithe <60528327+sbadithe@users.noreply.github.com>
Co-authored-by: Shripad Badithe <60528327+sbadithe@users.noreply.github.com>
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few relatively minor things, but generally looking pretty good to me.

ozzieD and others added 2 commits January 13, 2023 09:48
Co-authored-by: Nate Parsons <4307001+thehomebrewnerd@users.noreply.github.com>
@ozzieD ozzieD enabled auto-merge (squash) January 17, 2023 16:54
@ozzieD ozzieD disabled auto-merge January 17, 2023 17:31
pass
except Exception as e: # If error in calculating feature matrix pass on the recommendation
logger = logging.getLogger("featuretools")
logger.error(f"Exception in {f.primitive.name}: {str(e)}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about a message like this?

"Exception with feature {f.get_name()} with primitive {f.primitive.name}: {str(e)}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@ozzieD ozzieD merged commit e878a2e into main Jan 18, 2023
@ozzieD ozzieD deleted the create-recommended-primitives branch January 18, 2023 17:45
@ozzieD ozzieD mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants