-
Notifications
You must be signed in to change notification settings - Fork 909
Refactor building groupby features if require_direct_input
#2400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2400 +/- ##
==========================================
- Coverage 99.45% 99.44% -0.01%
==========================================
Files 331 331
Lines 20425 20432 +7
==========================================
+ Hits 20313 20319 +6
- Misses 112 113 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
input_features when checking path equality input_features when checking path equality
input_features when checking path equality input_features when checking path equality
input_features when checking path equality input_features when checking path equality
ozzieD
reviewed
Dec 13, 2022
ozzieD
reviewed
Dec 13, 2022
…heck' into reduce-traversals-in-same-path-check
…heck' into reduce-traversals-in-same-path-check
input_features when checking path equality require_direct_input
require_direct_input require_direct_input
rwedge
reviewed
Dec 16, 2022
rwedge
approved these changes
Dec 20, 2022
Contributor
rwedge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input_featurestwice because of the call to_features_have_same_path, but I think one traversal should do the trick_features_have_same_pathfunction_build_transform_features, removes function call and iterates once over the input_features. This reduces from three traversals to one (closes Reduce traversals over features in_build_transform_features#2402)