Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve empty series warnings #2403

Merged
merged 14 commits into from
Dec 22, 2022
Merged

Resolve empty series warnings #2403

merged 14 commits into from
Dec 22, 2022

Conversation

sbadithe
Copy link
Contributor

@sbadithe sbadithe commented Dec 14, 2022 •
edited
Loading

  • encountered these warnings when running tests
  • this should cover all the remaining cases

@sbadithe sbadithe changed the title Silence empty series warnings Resolve empty series warnings Dec 14, 2022
@sbadithe sbadithe marked this pull request as ready for review December 14, 2022 01:13
@codecov
Copy link

codecov bot commented Dec 14, 2022 •
edited
Loading

Codecov Report

Merging #2403 (74e9a90) into main (4055dd0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2403   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files         340      340           
  Lines       20870    20870           
=======================================
  Hits        20755    20755           
  Misses        115      115
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 99.22% <100.00%> (ø)
...tandard/transform/email/email_address_to_domain.py 100.00% <100.00%> (ø)
...s/standard/transform/email/is_free_email_domain.py 100.00% <100.00%> (ø)
...ts/primitive_tests/test_rolling_primitive_utils.py 100.00% <100.00%> (ø)
.../tests/primitive_tests/test_transform_primitive.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbadithe sbadithe enabled auto-merge (squash) December 14, 2022 01:23
@sbadithe sbadithe marked this pull request as draft December 14, 2022 18:27
auto-merge was automatically disabled December 14, 2022 18:27

Pull request was converted to draft

sbadithe and others added 7 commits December 20, 2022 13:05
@sbadithe @gsheni
Update featuretools/primitives/standard/transform/email/email_address…
dd13700 
…_to_domain.py

Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
@sbadithe @gsheni
Update featuretools/tests/primitive_tests/test_transform_primitive.py
da4ef4c 
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
@sbadithe @gsheni
Update featuretools/tests/primitive_tests/test_transform_primitive.py
40c884d 
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
@sbadithe @gsheni
Update featuretools/primitives/standard/transform/email/is_free_email…
453b03a 
…_domain.py

Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
@sbadithe @gsheni
Update featuretools/tests/primitive_tests/test_transform_primitive.py
5706f77 
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
@sbadithe @gsheni
Update featuretools/tests/primitive_tests/test_transform_primitive.py
19e1678 
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
@sbadithe
Merge branch 'main' into silence-empty-series-warnings
6ed17ad
@sbadithe sbadithe marked this pull request as ready for review December 20, 2022 21:06
@gsheni gsheni enabled auto-merge (squash) December 22, 2022 15:20
@gsheni gsheni merged commit bddadeb into main Dec 22, 2022
@gsheni gsheni deleted the silence-empty-series-warnings branch December 22, 2022 15:36
@thehomebrewnerd thehomebrewnerd mentioned this pull request Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsheni gsheni gsheni approved these changes

Assignees

@sbadithe sbadithe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbadithe @gsheni