Update RateOfChange input types to only accept Datetime time index#2408
Update RateOfChange input types to only accept Datetime time index#2408thehomebrewnerd merged 3 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2408 +/- ##
===========================================
+ Coverage 69.89% 99.44% +29.55%
===========================================
Files 326 326
Lines 20208 20208
===========================================
+ Hits 14124 20096 +5972
+ Misses 6084 112 -5972
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sbadithe
left a comment
There was a problem hiding this comment.
Do we need to add a test that numeric time indexes don't work?
I think that should already be covered by our features tests - we know DFS doesn't build features with input types that are not specified, so adding a specific test here seems unnecessary. The inclusion of all time index types in the primitive definition before was just an oversight. |
Makes sense to me! |
Update RateOfChange input types to only accept Datetime time index
Fixes #2395