Skip to content

Conversation

@thehomebrewnerd
Copy link
Contributor

Update init calls in add_last_time_indexes to use init_with_parital_schema

Fixes #1463

Note: The current Woodwork init call simply calls init_with_partial_schema and passes along all the specified kwargs, so this change does not alter any of the existing behavior, but just makes it more clear that we are reusing the existing schema information by calling init_with_partial_schema

Copy link
Contributor

@tamargrey tamargrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only thing I can think to add might be a test that mocks out the woodwork init and confirms it's not called, but given how minor of a change this is, that's probably overkill.

@thehomebrewnerd thehomebrewnerd enabled auto-merge (squash) December 16, 2022 21:30
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #2409 (9ab216c) into main (c6dfef6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2409   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files         326      326           
  Lines       20208    20208           
=======================================
  Hits        20096    20096           
  Misses        112      112           
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 99.22% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@thehomebrewnerd thehomebrewnerd merged commit 3ed040d into main Dec 16, 2022
@thehomebrewnerd thehomebrewnerd deleted the issue1463-lti-partial-schema branch December 16, 2022 21:32
@thehomebrewnerd thehomebrewnerd mentioned this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up EntitySet.add_last_time_indexes by initializing Woodwork with partial schema

4 participants