Fix backtracking in NumberOfWordsInQuotes primitive #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sbadithe
commented
Dec 19, 2022
•
sbadithe
commented
- closes NumberOfWordsInQuotes freezes on twitter dataset #2411
- adds the line that triggered catastrophic backtracking as test case
…mber-of-words-in-quotes' into fix-catastrophic-backtracking-number-of-words-in-quotes # Conflicts: # pyproject.toml
Codecov Report
@@ Coverage Diff @@
## main #2413 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 340 340
Lines 20870 20870
=======================================
Hits 20755 20755
Misses 115 115
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gsheni
changed the title
…mber-of-words-in-quotes' into fix-catastrophic-backtracking-number-of-words-in-quotes
gsheni
reviewed
Dec 19, 2022
...ls/tests/primitive_tests/natural_language_primitives_tests/test_number_of_words_in_quotes.py
Show resolved
Hide resolved
gsheni
approved these changes
Dec 20, 2022
sbadithe
deleted the
fix-catastrophic-backtracking-number-of-words-in-quotes
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.