Skip to content

Fix backtracking in NumberOfWordsInQuotes primitive#2413

Merged
sbadithe merged 15 commits into
mainfrom
fix-catastrophic-backtracking-number-of-words-in-quotes
Dec 20, 2022
Merged

Fix backtracking in NumberOfWordsInQuotes primitive#2413
sbadithe merged 15 commits into
mainfrom
fix-catastrophic-backtracking-number-of-words-in-quotes

Conversation

@sbadithe

@sbadithe sbadithe commented Dec 19, 2022

Copy link
Copy Markdown
Contributor

sbadithe and others added 5 commits December 18, 2022 22:32
…mber-of-words-in-quotes' into fix-catastrophic-backtracking-number-of-words-in-quotes

# Conflicts:
#	pyproject.toml
@codecov

codecov Bot commented Dec 19, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2413 (6d0ed92) into main (4ce3c2a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2413   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files         340      340           
  Lines       20870    20870           
=======================================
  Hits        20755    20755           
  Misses        115      115           
Impacted Files Coverage Δ
...form/natural_language/number_of_words_in_quotes.py 100.00% <100.00%> (ø)
...primitives_tests/test_number_of_words_in_quotes.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsheni gsheni changed the title fix catastrophic backtracking Fix backtracking in NumberOfWordsInQuotes primitive Dec 19, 2022
@sbadithe sbadithe marked this pull request as ready for review December 19, 2022 17:58
@sbadithe sbadithe requested a review from a team December 19, 2022 17:59
@sbadithe sbadithe merged commit 4055dd0 into main Dec 20, 2022
@sbadithe sbadithe deleted the fix-catastrophic-backtracking-number-of-words-in-quotes branch December 20, 2022 22:15
@thehomebrewnerd thehomebrewnerd mentioned this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NumberOfWordsInQuotes freezes on twitter dataset

2 participants