Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for numpy 1.24.0 #2414

Merged
merged 5 commits into from
Dec 19, 2022
Merged

Fix for numpy 1.24.0 #2414

merged 5 commits into from
Dec 19, 2022

Conversation

thehomebrewnerd
Copy link
Contributor

Fix for numpy 1.24.0

Use "object" string instead of np.object which has been removed.

@@ -75,6 +75,7 @@ test = [
spark = [
"woodwork[spark] >= 0.18.0",
"pyspark >= 3.2.2",
"numpy < 1.24.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create a new issue to remove this once pyspark is compatible

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #2414 (87fac24) into main (07d110c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2414   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files         326      326           
  Lines       20208    20208           
=======================================
  Hits        20096    20096           
  Misses        112      112           
Impacted Files Coverage Δ
...s/standard/transform/email/is_free_email_domain.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@thehomebrewnerd thehomebrewnerd requested a review from a team December 19, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants