Skip to content

Add TimeSinceLastFalse, TimeSinceLastMax, TimeSinceLastMin, TimeSinceLastTrue aggregation primitives - #2418

Merged
gsheni merged 7 commits into
mainfrom
time_since_prims
Dec 19, 2022
Merged

Add TimeSinceLastFalse, TimeSinceLastMax, TimeSinceLastMin, TimeSinceLastTrue aggregation primitives#2418
gsheni merged 7 commits into
mainfrom
time_since_prims

Conversation

@gsheni

@gsheni gsheni commented Dec 19, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@gsheni gsheni self-assigned this Dec 19, 2022
@gsheni
gsheni marked this pull request as ready for review December 19, 2022 18:04
@codecov

codecov Bot commented Dec 19, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2418 (71390a3) into main (7f35f73) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main    #2418    +/-   ##
========================================
  Coverage   99.44%   99.45%            
========================================
  Files         326      331     +5     
  Lines       20208    20425   +217     
========================================
+ Hits        20096    20313   +217     
  Misses        112      112            
Impacted Files Coverage Δ
...etools/primitives/standard/aggregation/__init__.py 100.00% <100.00%> (ø)
...ives/standard/aggregation/time_since_last_false.py 100.00% <100.00%> (ø)
...itives/standard/aggregation/time_since_last_max.py 100.00% <100.00%> (ø)
...itives/standard/aggregation/time_since_last_min.py 100.00% <100.00%> (ø)
...tives/standard/aggregation/time_since_last_true.py 100.00% <100.00%> (ø)
...turetools/tests/primitive_tests/test_time_since.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread featuretools/primitives/standard/aggregation/time_since_last_true.py Outdated
Comment thread featuretools/primitives/standard/aggregation/time_since_last_false.py Outdated
@gsheni
gsheni merged commit 84b7cd5 into main Dec 19, 2022
@gsheni
gsheni deleted the time_since_prims branch December 19, 2022 20:18
@thehomebrewnerd thehomebrewnerd mentioned this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants