Add MaxConsecutiveFalse, MaxConsecutiveNegatives, MaxConsecutivePositives, MaxConsecutiveTrue, MaxConsecutiveZeros, NumConsecutiveGreaterMean, NumConsecutiveLessMean by gsheni · Pull Request #2420 · alteryx/featuretools

gsheni · 2022-12-20T16:17:21Z

No description provided.

…_prims

codecov · 2022-12-20T16:37:04Z

Codecov Report

Merging #2420 (62f6011) into main (b3b3a9e) will increase coverage by 0.00%.
The diff coverage is 99.54%.

@@           Coverage Diff            @@
##             main    #2420    +/-   ##
========================================
  Coverage   99.44%   99.44%            
========================================
  Files         331      340     +9     
  Lines       20432    20870   +438     
========================================
+ Hits        20319    20755   +436     
- Misses        113      115     +2

Impacted Files	Coverage Δ
...etools/tests/entityset_tests/test_serialization.py	`100.00% <ø> (ø)`
...tests/primitive_tests/test_expanding_primitives.py	`100.00% <ø> (ø)`
...andard/aggregation/num_consecutive_greater_mean.py	`96.96% <96.96%> (ø)`
.../standard/aggregation/num_consecutive_less_mean.py	`96.96% <96.96%> (ø)`
...etools/primitives/standard/aggregation/__init__.py	`100.00% <100.00%> (ø)`
...ives/standard/aggregation/max_consecutive_false.py	`100.00% <100.00%> (ø)`
.../standard/aggregation/max_consecutive_negatives.py	`100.00% <100.00%> (ø)`
.../standard/aggregation/max_consecutive_positives.py	`100.00% <100.00%> (ø)`
...tives/standard/aggregation/max_consecutive_true.py	`100.00% <100.00%> (ø)`
...ives/standard/aggregation/max_consecutive_zeros.py	`100.00% <100.00%> (ø)`
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…o max_conse_prims

thehomebrewnerd

Looks like we have two new uncovered lines with these updates. Might be nice to add a test to cover those if it's not a big lift.

thehomebrewnerd · 2022-12-20T20:18:07Z

-        primitive_instance = self.primitive()
+    def test_regular(self, dtype):
+        if dtype == "int64":
+            pytest.skip("floats not supported in int64")


floats -> nans

No this was intentional message. I made a better one
a014517

Oh, I see. I didn't follow what was being tested closely enough.

thehomebrewnerd · 2022-12-20T20:19:24Z

-        primitive_instance = self.primitive()
+    def test_regular(self, dtype):
+        if dtype == "int64":
+            pytest.skip("floats not supported in int64")


floats -> nans

No this was intentional message. I made a better one
a014517

thehomebrewnerd · 2022-12-20T20:20:19Z

-        primitive_instance = self.primitive()
+    def test_regular(self, dtype):
+        if dtype == "int64":
+            pytest.skip("floats not supported in int64")


floats -> nans

No this was intentional message. I made a better one
a014517

thehomebrewnerd · 2022-12-20T20:20:29Z

-        primitive_instance = self.primitive()
+    def test_all_float(self, dtype):
+        if dtype == "int64":
+            pytest.skip("floats not supported in int64")


floats -> nans

No this was intentional message. I made a better one
a014517

thehomebrewnerd

Small nitpicks, but not blocking

thehomebrewnerd · 2022-12-20T20:29:04Z

    def test_all_float(self, dtype):
        if dtype == "int64":
-            pytest.skip("floats not supported in int64")
+            pytest.skip("test array contains floats which are not supported int64")


Nitpick: the floats used in this test could all be represented as integers. Should we change?

thehomebrewnerd · 2022-12-20T20:29:13Z

    def test_all_float(self, dtype):
        if dtype == "int64":
-            pytest.skip("floats not supported in int64")
+            pytest.skip("test array contains floats which are not supported int64")


Nitpick: the floats used in this test could all be represented as integers. Should we change?

Gaurav Sheni added 2 commits December 19, 2022 14:13

fix tests

2008121

Merge branch 'main' of github.com:alteryx/featuretools into max_conse…

68bda23

…_prims

gsheni requested a review from thehomebrewnerd December 20, 2022 16:17

gsheni self-assigned this Dec 20, 2022

fix release notes

4d8de90

gsheni marked this pull request as ready for review December 20, 2022 16:19

lint

c6b759a

Merge branch 'main' into max_conse_prims

9f30406

thehomebrewnerd reviewed Dec 20, 2022

View reviewed changes

Gaurav Sheni added 5 commits December 20, 2022 12:35

add backticks

4465dac

Merge branch 'max_conse_prims' of github.com:alteryx/featuretools int…

44bcec5

…o max_conse_prims

remove skipna

682f824

remove docstring skipna

1791854

remove notebook

1643160

gsheni requested a review from thehomebrewnerd December 20, 2022 18:45

Gaurav Sheni added 2 commits December 20, 2022 13:49

fix import

1054ee0

fix lint

5a331d6

gsheni enabled auto-merge (squash) December 20, 2022 18:52

Gaurav Sheni added 3 commits December 20, 2022 14:12

better tests

3457619

fix float regular

a854e84

fix test

b149f9b

thehomebrewnerd reviewed Dec 20, 2022

View reviewed changes

Comment thread featuretools/primitives/standard/aggregation/max_consecutive_positives.py

thehomebrewnerd reviewed Dec 20, 2022

View reviewed changes

Gaurav Sheni added 2 commits December 20, 2022 15:23

fix skips

a014517

fix message

62f6011

thehomebrewnerd approved these changes Dec 20, 2022

View reviewed changes

gsheni merged commit 4ce3c2a into main Dec 20, 2022

gsheni deleted the max_conse_prims branch December 20, 2022 20:45

thehomebrewnerd mentioned this pull request Jan 5, 2023

v1.20.0 #2436

Merged

Uh oh!

Conversation

gsheni commented Dec 20, 2022

Uh oh!

codecov Bot commented Dec 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thehomebrewnerd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thehomebrewnerd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Dec 20, 2022 •

edited

Loading