Fix fragmentation PerformanceWarning in feature_set_calculator.py - #2424
Merged
Conversation
thehomebrewnerd
marked this pull request as draft
December 22, 2022 15:21
thehomebrewnerd
commented
Dec 22, 2022
Comment on lines
+944
to
+951
| else: | ||
| for name, col in new_cols.items(): | ||
| col.name = name | ||
| if isinstance(data, dd.DataFrame): | ||
| data = dd.concat([data, col], axis=1) | ||
| else: | ||
| data = ps.concat([data, col], axis=1) | ||
| return data |
Contributor
Author
There was a problem hiding this comment.
I don't really like this approach for Dask/Spark, but we can't create a new dataframe from the columns here like we can for pandas, so we have to concat the columns one at a time. Maybe there is a better way, but I didn't come up with one off the top of my head.
thehomebrewnerd
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2424 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 340 340
Lines 20893 20908 +15
=======================================
+ Hits 20778 20793 +15
Misses 115 115
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
thehomebrewnerd
marked this pull request as ready for review
December 22, 2022 19:36
sbadithe
reviewed
Dec 22, 2022
sbadithe
reviewed
Dec 22, 2022
sbadithe
reviewed
Dec 22, 2022
sbadithe
reviewed
Dec 22, 2022
dvreed77
reviewed
Dec 28, 2022
rwedge
reviewed
Jan 3, 2023
Co-authored-by: Roy Wedge <roy.wedge@alteryx.com>
ozzieD
reviewed
Jan 3, 2023
ozzieD
approved these changes
Jan 4, 2023
gsheni
approved these changes
Jan 4, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2405
pandas.util"datetime"without units