-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global test for NaturalLanguage primitives #2429
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2429 +/- ##
==========================================
- Coverage 99.41% 99.40% -0.01%
==========================================
Files 340 341 +1
Lines 20870 20890 +20
==========================================
+ Hits 20747 20766 +19
- Misses 123 124 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I wonder why code cov is looking through test files? |
...etools/tests/primitive_tests/natural_language_primitives_tests/test_natural_language_perf.py
Outdated
Show resolved
Hide resolved
Codecov is configured to check our test files as well |
...mitive_tests/natural_language_primitives_tests/test_natural_language_primitives_terminate.py
Outdated
Show resolved
Hide resolved
…' into add-randomized-test-for-natlangs
Is it ok if it hasn't been updated since January 2022 on pypi? |
@sbadithe In my opinion, yes. This is a simple library, so I wouldn't expect many updates. Also, this is a test only dependency, so we can always replace in the future if needed and it won't break FT. Finally, it is maintained by the pytest folks. All those factors combined make it a low risk add IMHO. |
…' into add-randomized-test-for-natlangs # Conflicts: # featuretools/tests/primitive_tests/natural_language_primitives_tests/test_natural_language_primitives_terminate.py
as well as randomized test inputsto make sure none of our NaturalLanguage primitives hang or fail on generated input.get_natural_language_primitives
and refactorsget_transform_primitives
andget_aggregation_primitives
utility functions