Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization of word_set in NumberOfCommonWords #2432

Merged
merged 9 commits into from
Jan 3, 2023
Merged

Fix serialization of word_set in NumberOfCommonWords #2432

merged 9 commits into from
Jan 3, 2023

Conversation

sbadithe
Copy link
Contributor

@codecov
Copy link

codecov bot commented Dec 28, 2022 •
edited
Loading

Codecov Report

Merging #2432 (e933858) into main (ede3671) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2432   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files         340      340           
  Lines       20870    20893   +23     
=======================================
+ Hits        20755    20778   +23     
  Misses        115      115
Impacted Files Coverage Δ
featuretools/primitives/utils.py 99.46% <100.00%> (+0.01%) ⬆️
...ests/primitive_tests/test_feature_serialization.py 100.00% <100.00%> (ø)
...ests/primitive_tests/test_features_deserializer.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbadithe sbadithe marked this pull request as ready for review December 28, 2022 20:46
@sbadithe sbadithe requested review from rwedge and dvreed77 December 30, 2022 18:46
@sbadithe sbadithe changed the title fix serialization of word_set in NumberOfCommonWords Fix serialization of word_set in NumberOfCommonWords Dec 30, 2022
@gsheni gsheni requested a review from dvreed77 January 3, 2023 15:45
@gsheni gsheni assigned thehomebrewnerd and unassigned sbadithe Jan 3, 2023
@gsheni gsheni enabled auto-merge (squash) January 3, 2023 17:14
@gsheni gsheni merged commit a4768f2 into main Jan 3, 2023
@gsheni gsheni deleted the serialize-numberofcommonwords-customwordset branch January 3, 2023 17:24
@thehomebrewnerd thehomebrewnerd mentioned this pull request Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsheni gsheni gsheni approved these changes

@rwedge rwedge Awaiting requested review from rwedge

@dvreed77 dvreed77 Awaiting requested review from dvreed77

Assignees

@thehomebrewnerd thehomebrewnerd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't serialize NumberOfCommonWords feature with custom word set
4 participants
@sbadithe @dvreed77 @gsheni @thehomebrewnerd