Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with NumWords; add test suite #2459

Merged
merged 14 commits into from
Jan 24, 2023
Merged

Fix bug with NumWords; add test suite #2459

merged 14 commits into from
Jan 24, 2023

Conversation

sbadithe
Copy link
Contributor

@sbadithe sbadithe changed the title Fix bug with num words; add test suite Fix bug with NumWords; add test suite Jan 23, 2023
@sbadithe sbadithe marked this pull request as ready for review January 23, 2023 17:09
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #2459 (02fcd62) into main (931cc70) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2459   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files         343      344    +1     
  Lines       21056    21106   +50     
=======================================
+ Hits        20932    20982   +50     
  Misses        124      124           
Impacted Files Coverage Δ
...s/standard/transform/natural_language/num_words.py 100.00% <100.00%> (ø)
...atural_language_primitives_tests/test_num_words.py 100.00% <100.00%> (ø)
...s/tests/primitive_tests/test_transform_features.py 99.87% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbadithe sbadithe merged commit 55a10c8 into main Jan 24, 2023
@sbadithe sbadithe deleted the fix-num-words-bug branch January 24, 2023 21:43
@sbadithe sbadithe mentioned this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NumWords returns wrong answer when text with multiple spaces is passed in
2 participants