Add looking glass launch instructions #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsheni
reviewed
Jan 24, 2023
release.md
Outdated
| @@ -8,7 +8,7 @@ Before starting the release process, verify the following: | |||
| - [All Github Actions Tests are green on main](https://github.com/alteryx/featuretools/actions?query=branch%3Amain). | |||
| - EvalML Tests are green with Featuretools main | |||
| - [](https://github.com/alteryx/evalml/actions/workflows/unit_tests_with_featuretools_main_branch.yaml) | |||
| - The latest Looking Glass performance tests runs should not show any significant performance regressions. If performance regressions have been identified, review the results with the development team to decide on the proper course of action before proceeding with the release. | |||
| - Looking Glass performance tests runs should not show any significant performance regressions when comparing the last commit on `main` with the previous release of Featuretools. See below for instructions on manually launching the performance tests runs. If performance regressions have been identified, review the results with the development team to decide on the proper course of action before proceeding with the release. | |||
There was a problem hiding this comment.
Let's be more explicit here. The person releasing has to kickoff the performance tests, and look at the results.
There was a problem hiding this comment.
I worded it this way because this is in a list of things to verify, not a list of actions for the person releasing to do. Do you think the action required will be clear enough if we move the detailed instructions to Step 1 in the release process?
gsheni
reviewed
Jan 24, 2023
release.md
Outdated
| @@ -123,3 +123,17 @@ Per the instructions [here](https://conda-forge.org/docs/maintainer/updating_pkg | |||
|
|
|||
| 2. A PR will be auto-created on the repo, and will need to be merged by an existing maintainer. | |||
| 3. The new user will need to **check their email for an invite link to click**, which should be https://github.com/conda-forge | |||
|
|
|||
| ## Manually launching Looking Glass performance runs | |||
There was a problem hiding this comment.
Let's move this up, and make it one of the first steps to releasing.
added 2 commits
January 24, 2023 13:52
gsheni
reviewed
Jan 24, 2023
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
gsheni
reviewed
Jan 24, 2023
gsheni
approved these changes
Jan 24, 2023
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2461 +/- ##
=======================================
Coverage 99.41% 99.41%
=======================================
Files 343 343
Lines 21056 21056
=======================================
Hits 20932 20932
Misses 124 124 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
release.mdto include instructions on how to manually launch Looking Glass performance test runs.