Change TotalWordLength and UpperCaseWordCount to return IntegerNullable
#2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbadithe
changed the title
TotalWordLength and UpperCaseWordCount to return IntegerNullable
sbadithe
force-pushed
the
change-count-natlang-primitives-to-return-integernullable
branch
from
f878b18 to
30a76b6
Compare
sbadithe
force-pushed
the
change-count-natlang-primitives-to-return-integernullable
branch
from
dd729ba to
ed03939
Compare
Codecov Report
@@ Coverage Diff @@
## main #2474 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 355 355
Lines 21421 21421
=======================================
Hits 21297 21297
Misses 124 124
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gsheni
reviewed
Feb 1, 2023
featuretools/tests/primitive_tests/test_upper_case_word_count.py
Outdated
Show resolved
Hide resolved
gsheni
reviewed
Feb 1, 2023
featuretools/tests/primitive_tests/test_upper_case_word_count.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
gsheni
reviewed
Feb 1, 2023
featuretools/tests/primitive_tests/test_upper_case_word_count.py
Outdated
Show resolved
Hide resolved
gsheni
reviewed
Feb 1, 2023
featuretools/tests/primitive_tests/test_upper_case_word_count.py
Outdated
Show resolved
Hide resolved
…to-return-integernullable' into change-count-natlang-primitives-to-return-integernullable
gsheni
reviewed
Feb 1, 2023
gsheni
approved these changes
Feb 1, 2023
sbadithe
deleted the
change-count-natlang-primitives-to-return-integernullable
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntegerNullable seems more appropriate, as fractional values seem not to be possible.