Skip to content

Add AverageCountPerUnique, CountryCodeToContinent, FileExtension, FirstLastTimeDelta, SavgolFilter, CumulativeTimeSinceLastFalse, CumulativeTimeSinceLastTrue, PercentChange, PercentUnique#2485

Merged
gsheni merged 22 commits intomainfrom
add_trans_agg_primitives
Feb 17, 2023

Conversation

@gsheni
Copy link
Contributor

@gsheni gsheni commented Feb 13, 2023

@gsheni gsheni self-assigned this Feb 13, 2023
@gsheni gsheni marked this pull request as ready for review February 13, 2023 22:03
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #2485 (6b3b3f6) into main (527de6c) will increase coverage by 0.02%.
The diff coverage is 99.63%.

@@            Coverage Diff             @@
##             main    #2485      +/-   ##
==========================================
+ Coverage   99.42%   99.44%   +0.02%     
==========================================
  Files         355      367      +12     
  Lines       21421    21882     +461     
==========================================
+ Hits        21297    21760     +463     
+ Misses        124      122       -2     
Impacted Files Coverage Δ
...s/standard/transform/email/is_free_email_domain.py 100.00% <ø> (ø)
...ggregation_primitive_tests/test_max_consecutive.py 100.00% <ø> (ø)
...ggregation_primitive_tests/test_num_consecutive.py 100.00% <ø> (ø)
...regation_primitive_tests/test_rolling_primitive.py 100.00% <ø> (ø)
...sts/aggregation_primitive_tests/test_time_since.py 100.00% <ø> (ø)
...age_primitives_tests/test_upper_case_word_count.py 100.00% <ø> (ø)
...rm_primitive_tests/test_datetoholiday_primitive.py 100.00% <ø> (ø)
...rimitive_tests/test_distancetoholiday_primitive.py 100.00% <ø> (ø)
...sform_primitive_tests/test_expanding_primitives.py 100.00% <ø> (ø)
...orm_primitive_tests/test_exponential_primitives.py 100.00% <ø> (ø)
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing some files that seem like they don't belong:

  • kurtosis.py
  • max_count.py
  • max_min_delta.py
  • median_count.py
  • n_most_common_frequency.py
  • num_false_since_last_true.py
  • num_peaks.py
  • num_true_since_last_false.py
  • num_zero_crossings.py

These are all aggregation primitives that are in the primitives/standard/transform directory.

@gsheni gsheni merged commit 16a5b16 into main Feb 17, 2023
@gsheni gsheni deleted the add_trans_agg_primitives branch February 17, 2023 15:14
@ozzieD ozzieD mentioned this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants