Support Woodwork's update numeric inference (integers as strings)#2505
Merged
Support Woodwork's update numeric inference (integers as strings)#2505
Conversation
Contributor
gsheni
commented
Mar 9, 2023
gsheni
commented
- Fixes Support Woodwork's update numeric inference (integers as strings) #2504 2504
| df = pd.DataFrame( | ||
| { | ||
| "id": ["0", "1", "2"], | ||
| "id": [0, 1, 2], |
Contributor
There was a problem hiding this comment.
I think maybe we just want to set the LogicalType for ID on L943 (and remove L946) instead of relying on inference here? Maybe we should just set all the types regardless of the dataframe type. I'm not sure we need to rely on WW inference for anything in this test.
gsheni
commented
Mar 9, 2023
thehomebrewnerd
approved these changes
Mar 9, 2023
Contributor
thehomebrewnerd
left a comment
thehomebrewnerd
left a comment
There was a problem hiding this comment.
Looks good, assuming CI passes
Codecov Report
@@ Coverage Diff @@
## main #2505 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 367 367
Lines 21882 21882
=======================================
Hits 21760 21760
Misses 122 122
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.