Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Woodwork's update numeric inference (integers as strings) #2505

Merged
merged 7 commits into from
Mar 9, 2023
Merged

Support Woodwork's update numeric inference (integers as strings) #2505

merged 7 commits into from
Mar 9, 2023

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Mar 9, 2023

@gsheni gsheni requested a review from thehomebrewnerd March 9, 2023 16:33
@gsheni gsheni self-assigned this Mar 9, 2023
@gsheni gsheni marked this pull request as ready for review March 9, 2023 16:34
thehomebrewnerd
thehomebrewnerd reviewed Mar 9, 2023
View reviewed changes
featuretools/tests/entityset_tests/test_es.py Outdated
@@ -929,7 +929,7 @@ def test_handles_datetime_mismatch():
def test_dataframe_init(es):
df = pd.DataFrame(
{
"id": ["0", "1", "2"],
"id": [0, 1, 2],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe we just want to set the LogicalType for ID on L943 (and remove L946) instead of relying on inference here? Maybe we should just set all the types regardless of the dataframe type. I'm not sure we need to rely on WW inference for anything in this test.

@gsheni gsheni requested a review from thehomebrewnerd March 9, 2023 17:19
@gsheni gsheni enabled auto-merge (squash) March 9, 2023 17:19
thehomebrewnerd
thehomebrewnerd approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming CI passes

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #2505 (6d30287) into main (eab4527) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2505   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files         367      367           
  Lines       21882    21882           
=======================================
  Hits        21760    21760           
  Misses        122      122
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/test_es.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsheni gsheni disabled auto-merge March 9, 2023 18:38
@gsheni gsheni merged commit b625de7 into main Mar 9, 2023
@gsheni gsheni deleted the fix_int_cast branch March 9, 2023 18:51
@ozzieD ozzieD mentioned this pull request Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehomebrewnerd thehomebrewnerd thehomebrewnerd approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Woodwork's update numeric inference (integers as strings)
2 participants
@gsheni @thehomebrewnerd