-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FullNameToFirstName, FullNameToLastName, FullNameToTitle, Correlation, AutoCorrelation, DateFirstEvent #2507
Conversation
gsheni
commented
Mar 9, 2023
•
edited
Loading
edited
- Closes Add FullNameToFirstName, FullNameToLastName, FullNameToTitle primitives #2506
- Closes Add Autocorrelation, Correlation aggregation primitives #2508
- Closes Add DateFirstEvent aggregation primitive #2509
Codecov Report
@@ Coverage Diff @@
## main #2507 +/- ##
==========================================
- Coverage 99.44% 99.44% -0.01%
==========================================
Files 367 374 +7
Lines 21882 22173 +291
==========================================
+ Hits 21760 22049 +289
- Misses 122 124 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
def test_urls(self): | ||
# note this implementation incorrectly identifies the first | ||
# name for 'Oliva y Ocana, Dona. Fermina' | ||
primitive_func = self.primitive().get_function() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking, but more of a comment: one thing I would be interested in investigating is, over a large number of test suites, if we gain any performance by performing these initializations once at class level