Add FullNameToFirstName, FullNameToLastName, FullNameToTitle, Correlation, AutoCorrelation, DateFirstEvent#2507
Merged
Conversation
added 2 commits
March 9, 2023 13:39
Codecov Report
@@ Coverage Diff @@
## main #2507 +/- ##
==========================================
- Coverage 99.44% 99.44% -0.01%
==========================================
Files 367 374 +7
Lines 21882 22173 +291
==========================================
+ Hits 21760 22049 +289
- Misses 122 124 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sbadithe
reviewed
Mar 9, 2023
sbadithe
reviewed
Mar 9, 2023
| def test_urls(self): | ||
| # note this implementation incorrectly identifies the first | ||
| # name for 'Oliva y Ocana, Dona. Fermina' | ||
| primitive_func = self.primitive().get_function() |
Contributor
There was a problem hiding this comment.
Not blocking, but more of a comment: one thing I would be interested in investigating is, over a large number of test suites, if we gain any performance by performing these initializations once at class level
sbadithe
approved these changes
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.