Skip to content

Add FullNameToFirstName, FullNameToLastName, FullNameToTitle, Correlation, AutoCorrelation, DateFirstEvent#2507

Merged
gsheni merged 10 commits into
mainfrom
add_primitives
Mar 9, 2023
Merged

Add FullNameToFirstName, FullNameToLastName, FullNameToTitle, Correlation, AutoCorrelation, DateFirstEvent#2507
gsheni merged 10 commits into
mainfrom
add_primitives

Conversation

@gsheni
Copy link
Copy Markdown
Contributor

@gsheni gsheni commented Mar 9, 2023

@gsheni gsheni requested a review from thehomebrewnerd March 9, 2023 18:29
@gsheni gsheni self-assigned this Mar 9, 2023
Gaurav Sheni added 2 commits March 9, 2023 13:39
@gsheni gsheni marked this pull request as ready for review March 9, 2023 18:41
@gsheni gsheni changed the title Add FullNameToFirstName, FullNameToLastName, FullNameToTitle Add FullNameToFirstName, FullNameToLastName, FullNameToTitle, Correlation, AutoCorrelation, DateFirstEvent Mar 9, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 9, 2023

Codecov Report

Merging #2507 (0577a0a) into main (b625de7) will decrease coverage by 0.01%.
The diff coverage is 99.37%.

@@            Coverage Diff             @@
##             main    #2507      +/-   ##
==========================================
- Coverage   99.44%   99.44%   -0.01%     
==========================================
  Files         367      374       +7     
  Lines       21882    22173     +291     
==========================================
+ Hits        21760    22049     +289     
- Misses        122      124       +2     
Impacted Files Coverage Δ
featuretools/tests/testing_utils/mock_ds.py 100.00% <ø> (ø)
...rimitives/standard/aggregation/date_first_event.py 94.11% <94.11%> (ø)
...aggregation_primitive_tests/test_agg_primitives.py 99.45% <98.91%> (-0.55%) ⬇️
...etools/primitives/standard/aggregation/__init__.py 100.00% <100.00%> (ø)
...primitives/standard/aggregation/autocorrelation.py 100.00% <100.00%> (ø)
...ols/primitives/standard/aggregation/correlation.py 100.00% <100.00%> (ø)
...uretools/primitives/standard/transform/__init__.py 100.00% <100.00%> (ø)
...ives/standard/transform/full_name_to_first_name.py 100.00% <100.00%> (ø)
...tives/standard/transform/full_name_to_last_name.py 100.00% <100.00%> (ø)
...rimitives/standard/transform/full_name_to_title.py 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsheni gsheni requested a review from sbadithe March 9, 2023 20:20
Comment thread featuretools/utils/plot_utils.py
def test_urls(self):
# note this implementation incorrectly identifies the first
# name for 'Oliva y Ocana, Dona. Fermina'
primitive_func = self.primitive().get_function()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, but more of a comment: one thing I would be interested in investigating is, over a large number of test suites, if we gain any performance by performing these initializations once at class level

@gsheni gsheni enabled auto-merge (squash) March 9, 2023 20:44
@gsheni gsheni disabled auto-merge March 9, 2023 20:44
@gsheni gsheni merged commit 5e0fe05 into main Mar 9, 2023
@gsheni gsheni deleted the add_primitives branch March 9, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants