Skip to content

Add Kurtosis, MinCount, NumFalseSinceLastTrue, NumPeaks, NumTrueSinceLastFalse, NumZeroCrossings #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 9, 2023

Conversation

@gsheni gsheni self-assigned this Mar 9, 2023
@gsheni gsheni changed the title Add primitives 2 Add Kurtosis, MinCount, NumFalseSinceLastTrue, NumPeaks, NumTrueSinceLastFalse, NumZeroCrossings Mar 9, 2023
@gsheni gsheni requested a review from sbadithe March 9, 2023 20:58
@gsheni gsheni marked this pull request as ready for review March 9, 2023 20:58
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #2514 (cc25b3b) into main (5e0fe05) will increase coverage by 5.38%.
The diff coverage is 99.73%.

@@            Coverage Diff             @@
##             main    #2514      +/-   ##
==========================================
+ Coverage   94.06%   99.45%   +5.38%     
==========================================
  Files         374      379       +5     
  Lines       22173    22549     +376     
==========================================
+ Hits        20857    22426    +1569     
+ Misses       1316      123    -1193     
Impacted Files Coverage Δ
...tools/primitives/standard/aggregation/min_count.py 100.00% <ø> (ø)
.../standard/aggregation/num_false_since_last_true.py 95.45% <95.45%> (ø)
...etools/primitives/standard/aggregation/__init__.py 100.00% <100.00%> (ø)
...etools/primitives/standard/aggregation/kurtosis.py 100.00% <100.00%> (ø)
...tools/primitives/standard/aggregation/num_peaks.py 100.00% <100.00%> (ø)
.../standard/aggregation/num_true_since_last_false.py 100.00% <100.00%> (ø)
...mitives/standard/aggregation/num_zero_crossings.py 100.00% <100.00%> (ø)
...aggregation_primitive_tests/test_agg_primitives.py 100.00% <100.00%> (+0.54%) ⬆️
...ggregation_primitive_tests/test_num_consecutive.py 100.00% <100.00%> (ø)

... and 16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsheni gsheni merged commit 22c0667 into main Mar 9, 2023
@gsheni gsheni deleted the add_primitives_2 branch March 9, 2023 21:39
@ozzieD ozzieD mentioned this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants