Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HasNoDuplicates, NthWeekOfMonth, HasNoDuplicates, IsMonotonicallyDecreasing, IsMonotonicallyIncreasing #2537

Merged
merged 19 commits into from
Apr 12, 2023

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Apr 7, 2023

@gsheni gsheni changed the title add additional primitives Add HasNoDuplicates, NthWeekOfMonth, HasNoDuplicates, IsMonotonicallyDecreasing, IsMonotonicallyIncreasing Apr 7, 2023
@gsheni gsheni self-assigned this Apr 7, 2023
@gsheni gsheni requested a review from rwedge April 7, 2023 20:16
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #2537 (bdec096) into main (34ff138) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main    #2537    +/-   ##
========================================
  Coverage   99.46%   99.46%            
========================================
  Files         389      392     +3     
  Lines       22999    23153   +154     
========================================
+ Hits        22876    23030   +154     
  Misses        123      123            
Impacted Files Coverage Δ
...etools/primitives/standard/aggregation/__init__.py 100.00% <100.00%> (ø)
...retools/primitives/standard/aggregation/entropy.py 100.00% <100.00%> (ø)
...imitives/standard/aggregation/has_no_duplicates.py 100.00% <100.00%> (ø)
...tandard/aggregation/is_monotonically_decreasing.py 100.00% <100.00%> (ø)
...tandard/aggregation/is_monotonically_increasing.py 100.00% <100.00%> (ø)
...tools/primitives/standard/aggregation/is_unique.py 100.00% <100.00%> (ø)
...etools/primitives/standard/aggregation/kurtosis.py 100.00% <100.00%> (ø)
...tools/primitives/standard/aggregation/num_peaks.py 100.00% <100.00%> (ø)
...uretools/primitives/standard/transform/__init__.py 100.00% <100.00%> (ø)
...ives/standard/transform/full_name_to_first_name.py 100.00% <100.00%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsheni gsheni marked this pull request as ready for review April 11, 2023 17:18
@gsheni gsheni requested a review from rwedge April 11, 2023 17:18
@gsheni gsheni requested a review from dvreed77 April 11, 2023 17:35
Copy link
Contributor

@dvreed77 dvreed77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsheni gsheni enabled auto-merge (squash) April 12, 2023 22:00
@gsheni gsheni merged commit f48f628 into main Apr 12, 2023
@gsheni gsheni deleted the add_primitives_part_2 branch April 12, 2023 22:20
@gsheni gsheni mentioned this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HasNoDuplicates, NthWeekOfMonth, HasNoDuplicates, IsMonotonicallyDecreasing, IsMonotonicallyIncreasing
3 participants