Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add premium primitives install command #2545

Merged
merged 13 commits into from
Apr 18, 2023
Merged

Add premium primitives install command #2545

merged 13 commits into from
Apr 18, 2023

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Apr 14, 2023 •
edited
Loading

@gsheni gsheni changed the title Update README.md Add premium primitives install command Apr 14, 2023
@gsheni gsheni self-assigned this Apr 14, 2023
@gsheni gsheni marked this pull request as ready for review April 14, 2023 15:39
@codecov
Copy link

codecov bot commented Apr 14, 2023 •
edited
Loading

Codecov Report

Merging #2545 (047e4b3) into main (ca20f13) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2545   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files         392      392           
  Lines       23153    23153           
=======================================
  Hits        23030    23030           
  Misses        123      123
Impacted Files Coverage Δ
...tives/standard/transform/datetime/days_in_month.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dvreed77
dvreed77 reviewed Apr 18, 2023
View reviewed changes
pyproject.toml Outdated
@@ -77,6 +77,9 @@ updater = [
tsfresh = [
"featuretools-tsfresh-primitives >= 1.0.0",
]
primitives = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would premium be a better name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely. Done.

gsheni
gsheni commented Apr 18, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
gsheni
gsheni commented Apr 18, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@gsheni gsheni requested a review from dvreed77 April 18, 2023 14:55
gsheni
gsheni commented Apr 18, 2023
View reviewed changes
docs/source/install.md Outdated Show resolved Hide resolved
gsheni
gsheni commented Apr 18, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
dvreed77
dvreed77 approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@dvreed77 dvreed77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsheni gsheni merged commit 7017e5b into main Apr 18, 2023
@gsheni gsheni deleted the add_premium_primitives_install branch April 18, 2023 16:30
@dvreed77 dvreed77 mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvreed77 dvreed77 dvreed77 approved these changes

@thehomebrewnerd thehomebrewnerd Awaiting requested review from thehomebrewnerd

@rwedge rwedge Awaiting requested review from rwedge

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add premium primitives install command
2 participants
@gsheni @dvreed77