Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle where clause when no child data #258

Merged
merged 3 commits into from
Sep 17, 2018
Merged

Conversation

kmax12
Copy link
Contributor

@kmax12 kmax12 commented Sep 15, 2018

Handles case where there is no child data for a aggregation feature with a where clause. The issue is that getting zero rows from the empty dataframe returned a new dataframe without column names resulting in an error later in the calculation.

Fixes #256

@WillKoehrsen WillKoehrsen self-assigned this Sep 17, 2018
@WillKoehrsen
Copy link
Contributor

Looks good to me!

@kmax12 kmax12 merged commit 708ba1f into master Sep 17, 2018
@kmax12 kmax12 mentioned this pull request Sep 28, 2018
@kmax12 kmax12 deleted the where-empty-baseframe branch October 2, 2018 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants