Add pandas 2.0 support#2585
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2585 +/- ##
===========================================
+ Coverage 87.74% 99.47% +11.73%
===========================================
Files 393 403 +10
Lines 23271 24198 +927
===========================================
+ Hits 20419 24071 +3652
+ Misses 2852 127 -2725
|
sbadithe
reviewed
Jul 17, 2023
| primitive_func = self.primitive().get_function() | ||
| given_answer = primitive_func(data) | ||
| assert np.isclose(answer, given_answer, atol=0.01) | ||
| if dtype == "float64": |
Contributor
There was a problem hiding this comment.
This is not a blocker (more of an incidental comment), but seeing the if clause here makes me consider if we should eventually refactor this test. Given that the previous data objects are being cast to float64 dtype as well, and the test previously did not require if clauses, it seems like there are three separate classes of behaviors here:
- How the kurtosis method handles the int64 dtype
- How the kurtosis primitive handles the float64 dtype when the data "looks like" an int64 (evidently this doesn't seem to differ from the previous class)
- How the kurtosis primitive handles the float64 dtype when the data are "true" floats
Separating those at some point might help to better document this primitive's behavior.
sbadithe
approved these changes
Jul 17, 2023
gsheni
approved these changes
Jul 18, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pandas 2.0 support
Closes #2532
Closes #2556