New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is_string
utils function
#260
Conversation
aa60be9
to
8bfb59f
Compare
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 94.14% 94.13% -0.01%
==========================================
Files 71 71
Lines 7632 7638 +6
==========================================
+ Hits 7185 7190 +5
- Misses 447 448 +1
Continue to review full report at Codecov.
|
is_string
utils functionis_string
utils function
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 94.14% 94.14% +<.01%
==========================================
Files 71 71
Lines 7632 7638 +6
==========================================
+ Hits 7185 7191 +6
Misses 447 447
Continue to review full report at Codecov.
|
is_string
utils functionis_string
utils function
Looks good. merging |
This PR replaces the python2 style
isinstance(value, basestring)
with a utils functionis_string(value)
. It replaces the importfrom past.builtins import basestring
with our own functionfrom featuretools.utils import is_string
. The only other use ofpast.builtins
is inserialization.py
where we importunicode
.This is related to #255 and the associated issue #254.