New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Entity methods #262
Conversation
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
+ Coverage 94.14% 94.43% +0.29%
==========================================
Files 71 71
Lines 7632 7639 +7
==========================================
+ Hits 7185 7214 +29
+ Misses 447 425 -22
Continue to review full report at Codecov.
|
assert 'Updated dataframe contains 13 columns, expecting 12' in str(excinfo) | ||
|
||
|
||
def test_add_variable(es): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather than add a test for add_variable, let's just remove the function. it's only used in one place internally and we can probably avoid needing it at all
It seems it's not possible to satisfy the conditional
which used If there is a situation which can happen, it would be easy to add the relevant lines from |
@Seth-Rothschild ya, that makes sense to me. let's remove that code block and the add_variables function. edit: looks like you already did. |
Looks good. Merging |
This PR adds three tests and fixes the
add_variable
method for Entity.entity.add_variable
entity.add_variable
entity.update_data
elif unit == 'Y'
block inadd_td