Skip to content

remove looking_glass_performance_tests #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

petejanuszewski1
Copy link
Contributor

closes #2619

removed looking_glass_performance_tests.yaml

@thehomebrewnerd
Copy link
Contributor

@petejanuszewski1 The latest release of holidays broke our unit tests. I think you are might need to pin holidays<0.33 in pyproject.toml or alternatively update the failing tests before the CI checks will pass on this PR.

pyproject.toml Outdated
@@ -31,7 +31,7 @@ license = {text = "BSD 3-clause"}
requires-python = ">=3.8,<4"
dependencies = [
"cloudpickle >= 1.5.0",
"holidays >= 0.13",
"holidays < 0.33",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to still include >=0.13 here as older versions might be problematic.

"holidays >= 0.13, <0.33"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, makes sense. I'll update.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d279a48) 99.47% compared to head (69078c9) 99.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2620   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files         403      403           
  Lines       24201    24201           
=======================================
  Hits        24074    24074           
  Misses        127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petejanuszewski1 petejanuszewski1 merged commit 0c17474 into main Sep 20, 2023
@petejanuszewski1 petejanuszewski1 deleted the 2619_remove_lg_perf_test_workflow branch September 20, 2023 14:27
@thehomebrewnerd thehomebrewnerd mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old performance testing workflow (non airflow)
2 participants