Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle no child data when calculating aggregation features with multiple arguments #264

merged 6 commits into from Sep 20, 2018


Copy link

@kmax12 kmax12 commented Sep 19, 2018

This pull requests updates how we handle calculating aggregation features when there is no child data. We fixed this for aggregations with where features in #258, but this fixes it for when there are multiple arguments to the agg feature.

This PR fixes the second issue reported in #252

Copy link

codecov-io commented Sep 19, 2018

Codecov Report

Merging #264 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
+ Coverage   94.14%   94.15%   +<.01%     
  Files          71       71              
  Lines        7638     7649      +11     
+ Hits         7191     7202      +11     
  Misses        447      447
Impacted Files Coverage Δ
...turetools/computational_backends/ 94.13% <100%> (+0.06%) ⬆️
...tests/computational_backend/ 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36760c8...44c33e2. Read the comment docs.

@kmax12 kmax12 requested a review from rwedge September 20, 2018 18:30

# cutoff time after all rows, but where clause filters all rows
ft.calculate_feature_matrix(entityset=es, features=[count], cutoff_time=pd.Timestamp("1/4/2018"))
ft.calculate_feature_matrix(entityset=es, features=[count, count_where, trend], cutoff_time=pd.Timestamp("1/4/2018"))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add assertions here to confirm we get expected feature values from these matrices?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@kmax12 kmax12 merged commit 88b57d0 into master Sep 20, 2018
@kmax12 kmax12 mentioned this pull request Sep 28, 2018
@kmax12 kmax12 deleted the handle-empty-baseframe branch October 2, 2018 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants