Handle no child data when calculating aggregation features with multiple arguments#264
Merged
Handle no child data when calculating aggregation features with multiple arguments#264
Conversation
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
==========================================
+ Coverage 94.14% 94.15% +<.01%
==========================================
Files 71 71
Lines 7638 7649 +11
==========================================
+ Hits 7191 7202 +11
Misses 447 447
Continue to review full report at Codecov.
|
rwedge
reviewed
Sep 20, 2018
|
|
||
| # cutoff time after all rows, but where clause filters all rows | ||
| ft.calculate_feature_matrix(entityset=es, features=[count], cutoff_time=pd.Timestamp("1/4/2018")) | ||
| ft.calculate_feature_matrix(entityset=es, features=[count, count_where, trend], cutoff_time=pd.Timestamp("1/4/2018")) |
Contributor
There was a problem hiding this comment.
Could we add assertions here to confirm we get expected feature values from these matrices?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests updates how we handle calculating aggregation features when there is no child data. We fixed this for aggregations with where features in #258, but this fixes it for when there are multiple arguments to the agg feature.
This PR fixes the second issue reported in #252