Handling return type when creating features from DatetimeTimeIndex#266
Merged
Handling return type when creating features from DatetimeTimeIndex#266
Conversation
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
+ Coverage 94.45% 94.46% +<.01%
==========================================
Files 71 71
Lines 7670 7690 +20
==========================================
+ Hits 7245 7264 +19
- Misses 425 426 +1
Continue to review full report at Codecov.
|
kmax12
changed the title
rwedge
reviewed
Sep 25, 2018
rwedge
reviewed
Sep 26, 2018
| last = Last(es["log"]["datetime"], es["customers"]) | ||
| assert last.variable_type == Datetime | ||
|
|
||
| nti = NumericTimeIndex("datetime", es["log"]) # create a numeric time index variable |
Contributor
There was a problem hiding this comment.
maybe a little cleaner to make a second test using the with_integer_time_index option for make_ecommerce_entityset instead
Contributor
|
Looks good! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue reported in #265.
That issue surfaced as a calculation error, but the the underlying problem was incorrectly stacking features that shouldn’t exist. This PR updates the return type so the invalid feature doesn’t get created.