Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for python 3.7 #277

Merged
merged 10 commits into from
Oct 12, 2018
Merged

Update tests for python 3.7 #277

merged 10 commits into from
Oct 12, 2018

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Oct 3, 2018 •
edited
Loading

  • CircleCi will now run tests in python 3.7
  • use fastparquet instead of pyarrow for tests because pyarrow does not currently support python 3.7
  • fix warning for pd.concat
  • updated test_requirements.txt package versions to most recent.
  • ignore DeprecationWarning and PendingDeprecationWarning in pytest

@codecov-io
Copy link

codecov-io commented Oct 3, 2018 •
edited
Loading

Codecov Report

Merging #277 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #277   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files          71       71           
  Lines        7700     7700           
=======================================
  Hits         7273     7273           
  Misses        427      427
Impacted Files Coverage Δ
...utational_backend/test_calculate_feature_matrix.py 99.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da09b20...d01acba. Read the comment docs.

@gsheni gsheni changed the title [WIP] Update tests for python 3.7 Update tests for python 3.7 Oct 3, 2018
@gsheni gsheni requested a review from kmax12 October 6, 2018 00:17
@kmax12 kmax12 requested a review from rwedge October 10, 2018 21:47
rwedge
rwedge reviewed Oct 11, 2018
View reviewed changes
test-requirements.txt Outdated
@@ -2,4 +2,4 @@ pytest==3.5.1
mock==2.0.0
pytest-xdist==1.20.1
pytest-cov==2.5.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try updating these packages to their most recent version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@rwedge
Copy link
Contributor

rwedge commented Oct 11, 2018

Looks good

@kmax12 kmax12 merged commit c69a9da into master Oct 12, 2018
@gsheni gsheni deleted the python_37 branch October 12, 2018 15:09
@rwedge rwedge mentioned this pull request Oct 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge left review comments

@kmax12 kmax12 Awaiting requested review from kmax12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gsheni @codecov-io @rwedge @kmax12