Allow where clauses on direct features in Deep Feature Synthesis #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 94.45% 94.45% +<.01%
==========================================
Files 71 71
Lines 7698 7705 +7
==========================================
+ Hits 7271 7278 +7
Misses 427 427
Continue to review full report at Codecov.
|
|
This fixed my issue! Thank you so much for the very quick help, this is really amazing! |
rwedge
reviewed
Oct 12, 2018
| @@ -34,6 +34,8 @@ def make_ecommerce_files(with_integer_time_index=False, base_path=None, file_loc | |||
| product_df = pd.DataFrame({'id': ['Haribo sugar-free gummy bears', 'car', | |||
| 'toothpaste', 'brown bag', 'coke zero', | |||
| 'taco clock'], | |||
| 'department': ["food", "electronics", "food", | |||
There was a problem hiding this comment.
Maybe "health" for the toothpaste's department type?
rwedge
reviewed
Oct 12, 2018
| @@ -544,6 +549,7 @@ def test_where_different_base_feats(es): | |||
| assert hashed not in where_feats | |||
|
|
|||
|
|
|||
| # TODO: not clear what this tests | |||
There was a problem hiding this comment.
Should we add this as a backlog issue?
|
@rwedge addressed your comments. does this look good to merge? |
|
Looks good |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
DFS will automatically add where clauses to aggregation features based on the values in the
interesting_valuesproperty of another variable within that entity.This PR allows DFS to add where clauses using the interesting values of a direct feature. To accomplish this I added a variable property to direct features that used to only be defined for identity features.
First reported by @favstats on stackoverflow: https://stackoverflow.com/questions/52673694/specifying-interesting-variables-with-featuretools-does-not-work