-
Notifications
You must be signed in to change notification settings - Fork 896
Allow where clauses on direct features in Deep Feature Synthesis #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 94.45% 94.45% +<.01%
==========================================
Files 71 71
Lines 7698 7705 +7
==========================================
+ Hits 7271 7278 +7
Misses 427 427
Continue to review full report at Codecov.
|
This fixed my issue! Thank you so much for the very quick help, this is really amazing! |
@@ -34,6 +34,8 @@ def make_ecommerce_files(with_integer_time_index=False, base_path=None, file_loc | |||
product_df = pd.DataFrame({'id': ['Haribo sugar-free gummy bears', 'car', | |||
'toothpaste', 'brown bag', 'coke zero', | |||
'taco clock'], | |||
'department': ["food", "electronics", "food", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "health" for the toothpaste's department type?
@@ -544,6 +549,7 @@ def test_where_different_base_feats(es): | |||
assert hashed not in where_feats | |||
|
|||
|
|||
# TODO: not clear what this tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add this as a backlog issue?
@rwedge addressed your comments. does this look good to merge? |
Looks good |
DFS will automatically add where clauses to aggregation features based on the values in the
interesting_values
property of another variable within that entity.This PR allows DFS to add where clauses using the interesting values of a direct feature. To accomplish this I added a variable property to direct features that used to only be defined for identity features.
First reported by @favstats on stackoverflow: https://stackoverflow.com/questions/52673694/specifying-interesting-variables-with-featuretools-does-not-work