Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parents property of Entity #283

merged 7 commits into from Oct 18, 2018

Remove unused parents property of Entity #283

merged 7 commits into from Oct 18, 2018


Copy link

@kmax12 kmax12 commented Oct 12, 2018

This PR removes the unused parents property of the Entity class.

The was one usage of it, but that was refactored

Also, remove test case

Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #283 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
+ Coverage   94.44%   94.44%   +<.01%     
  Files          71       71              
  Lines        7719     7711       -8     
- Hits         7290     7283       -7     
+ Misses        429      428       -1
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/ 100% <ø> (ø) ⬆️
featuretools/entityset/ 93.45% <ø> (-0.04%) ⬇️
featuretools/entityset/ 93.8% <100%> (ø) ⬆️
featuretools/utils/ 70.58% <0%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ea5d7...43453da. Read the comment docs.

@kmax12 kmax12 requested a review from rwedge October 17, 2018 20:37
rwedge approved these changes Oct 17, 2018
Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kmax12 kmax12 merged commit b628ef1 into master Oct 18, 2018
@kmax12 kmax12 deleted the parent_cleanup branch October 18, 2018 20:15
@rwedge rwedge mentioned this pull request Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants