Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve time index validation #285

merged 3 commits into from Oct 17, 2018

Improve time index validation #285

merged 3 commits into from Oct 17, 2018


Copy link

@kmax12 kmax12 commented Oct 12, 2018

Minor fix converting an elif to if. In the current code, if the code paths related to index were taken, the elif to handle the time index wouldn't get called.

Our test case for this didn't check error message so it was passing. This has been updated. Also added another test related to another unchecked message.

Copy link

Codecov Report

Merging #285 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
+ Coverage   94.44%   94.47%   +0.02%     
  Files          71       71              
  Lines        7704     7708       +4     
+ Hits         7276     7282       +6     
+ Misses        428      426       -2
Impacted Files Coverage Δ
featuretools/entityset/ 93.82% <100%> (+0.18%) ⬆️
featuretools/tests/entityset_tests/ 99.36% <100%> (ø) ⬆️
featuretools/utils/ 70.58% <0%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69a9da...d6d53b0. Read the comment docs.

@kmax12 kmax12 requested review from WillKoehrsen and removed request for WillKoehrsen October 15, 2018 20:53
@kmax12 kmax12 merged commit b2a159c into master Oct 17, 2018
@gsheni gsheni deleted the time-index-check branch October 24, 2018 15:37
@rwedge rwedge mentioned this pull request Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants