Encode features with "unknown" class in categorical #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed the fix to be much simpler: Unknown classes are now encoded as |
kmax12
reviewed
Oct 15, 2018
| defaults to True | ||
| to_encode (list[str]): List of feature names to encode. | ||
| features not in this list are unencoded in the output matrix | ||
| defaults to encode all necessary features. | ||
| inplace (bool): Encode feature_matrix in place. Defaults to False. | ||
| verbose (str): Print progress info. | ||
| unknown_token (str): token used to replace unknown class in categorical column. |
There was a problem hiding this comment.
i don't think we need this anymore
|
fix linting and address my one comment, then it's good to merge. |
|
Looks good. Merging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Addresses #280 by checking for
"unknown"class in a categorical column to be encoded and adding anunknown_tokenparameter to specify the string used to stand in for the unknown class. If "unknown" is present in the column andunknown_token="unknown", anAssertionErroris raised telling the user to change theunknown_tokenparameter.