-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up unused methods #293
Conversation
Did the |
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
=========================================
Coverage ? 94.73%
=========================================
Files ? 71
Lines ? 7668
Branches ? 0
=========================================
Hits ? 7264
Misses ? 404
Partials ? 0
Continue to review full report at Codecov.
|
you're right, it didn't. just fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Made minor changes that clean up the code. No api changes.
Changes
Relationship.get_other_variable
because the method wasn't usedRelationship.get_other_entity
because it was only used one. Added logic toEntity.related_instances
insteadRelationship.get_entity_variable
because it was only used one. Added logic toEntity.related_instances
insteadRelationship._get_link_variable_name
andEntitySet. gen_relationship_var
because they did the same thing and it isn't really a method of either of those classes. Created methodget_relationship_variable_id
in our utils file instead._check_variable_list
,_check_variable
, and_check_entity
from wrangle.pyEntity.is_child_of
andEntity.is_parent_of
EntitySet.get_relationships
make_index_variable_name
RedirectStdStreams
Discrete.percent_unique
. this property access other properties that are no longer defined onVariable