Refactor EntitySet.find_path(...) #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 95.01% 95.04% +0.02%
==========================================
Files 71 71
Lines 7627 7621 -6
==========================================
- Hits 7247 7243 -4
+ Misses 380 378 -2
Continue to review full report at Codecov.
|
# Conflicts: # .circleci/config.yml
rwedge
requested changes
Oct 29, 2018
featuretools/entityset/entityset.py
Outdated
| start_node = BFSNode(start_entity_id, None, None) | ||
| queue = [start_node] | ||
| nodes = {} | ||
| # Search for bath using BFS to get the shortest path. |
rwedge
reviewed
Oct 29, 2018
featuretools/entityset/entityset.py
Outdated
| for r in next_relationships: | ||
| queue.append(current_path + [r]) | ||
|
|
||
| visited.add(next_entity_id) | ||
|
|
||
| raise ValueError(("No path from {} to {}! Check that all entities " | ||
| .format(start_entity_id, goal_entity_id)), |
There was a problem hiding this comment.
Not tested according to codecov
rwedge
reviewed
Oct 29, 2018
| :func:`BaseEntitySet.find_forward_path` | ||
| :func:`BaseEntitySet.find_backward_path` | ||
| :func:`EntitySet.find_forward_path` | ||
| :func:`EntitySet.find_backward_path` | ||
| """ | ||
| if start_entity_id == goal_entity_id: | ||
| if include_num_forward: | ||
| return [], 0 | ||
| else: | ||
| return [] |
There was a problem hiding this comment.
This else case not tested according to codecov
rwedge
reviewed
Oct 29, 2018
rwedge
approved these changes
Oct 29, 2018
|
Looks good |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR simply rewrites the bread first search algorithm we use to find a path between two nodes.
Our existing approach defined an new class to do it, which resulted in bloated code.
The changes here remove that extra class and adds comments to create cleaner and more understandable code.