Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pympler to test requirements #299

merged 1 commit into from Oct 30, 2018


Copy link

@rwedge rwedge commented Oct 30, 2018

  • Remove pympler import in gen_utils file and import it directly in testing files that use it
  • Move pympler requirement from general requirements to testing requirements.

Copy link

Codecov Report

Merging #299 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
- Coverage   95.04%   95.03%   -0.01%     
  Files          71       71              
  Lines        7621     7620       -1     
- Hits         7243     7242       -1     
  Misses        378      378
Impacted Files Coverage Δ
featuretools/utils/ 88.09% <ø> (-0.28%) ⬇️
...ols/tests/dfs_tests/ 98.45% <100%> (ø) ⬆️
...ests/feature_function_tests/ 97.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 512945d...57f95f7. Read the comment docs.

@rwedge rwedge requested a review from kmax12 October 30, 2018 20:13
Copy link

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Go ahead and merge

@rwedge rwedge merged commit 10d92ac into master Oct 30, 2018
@rwedge rwedge mentioned this pull request Oct 31, 2018
@rwedge rwedge deleted the make-pympler-test-requirement branch June 11, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants