Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add associative attribute to primitives #3

merged 5 commits into from Oct 4, 2017


Copy link

@rwedge rwedge commented Oct 3, 2017

Some primitives, given a set of base features, will give the same feature values regardless of order.

Add(feature_A, feature_B) functions the same as Add(feature_b, feature_A).

By flagging a primitive as associative, DeepFeatureSynthesis will only create one instance of that primitive per unique set of base features.

Also subclassed the Compare primitive into six primitives: Equals, NotEquals, GreaterThan, GreaterThanEqualTo, LessThan, and LessThanEqualTo.

Copy link

CLAassistant commented Oct 3, 2017

CLA assistant check
All committers have signed the CLA.

Copy link

kmax12 commented Oct 4, 2017

Looks good to me

@kmax12 kmax12 merged commit 5eb9cce into master Oct 4, 2017
@kmax12 kmax12 deleted the symmetric_primitives branch October 11, 2017 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants