Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Pandas Backend #302

merged 6 commits into from Nov 27, 2018

Clean up Pandas Backend #302

merged 6 commits into from Nov 27, 2018


Copy link

@kmax12 kmax12 commented Oct 31, 2018

This PR removes some unused lines from Pandas Backend.

Just a minor change to clean up code. No API changes

Copy link

codecov-io commented Oct 31, 2018

Codecov Report

Merging #302 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
+ Coverage   95.13%   95.21%   +0.08%     
  Files          71       71              
  Lines        7702     7687      -15     
- Hits         7327     7319       -8     
+ Misses        375      368       -7
Impacted Files Coverage Δ
...turetools/computational_backends/ 96.89% <ø> (+2.76%) ⬆️
featuretools/utils/ 85.71% <0%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3cf61...7ff1144. Read the comment docs.

@kmax12 kmax12 requested a review from rwedge November 2, 2018 21:32
Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rwedge rwedge merged commit ba0923f into master Nov 27, 2018
@rwedge rwedge mentioned this pull request Nov 29, 2018
@kmax12 kmax12 deleted the unused-lines-pandas-backend branch December 1, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants