Update properties of cumulative transform primitives #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
==========================================
+ Coverage 95.12% 95.12% +<.01%
==========================================
Files 71 71
Lines 7705 7714 +9
==========================================
+ Hits 7329 7338 +9
Misses 376 376
Continue to review full report at Codecov.
|
rwedge
reviewed
Nov 26, 2018
|
|
||
| def test_cum_handles_uses_full_entity(es): | ||
| log_value_feat = es['log']['value'] | ||
| for primitive in [CumSum, CumMean, CumMax, CumMax]: |
There was a problem hiding this comment.
CumMax is in the list twice and CumCount and CumMin are not present.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cumulative transform primitives had an incorrectly define property. It was named
needs_all_valueswhen it should have beenuses_full_entity.This PR fixes that and adds a test.
fixes #317 reported by @MarekHauzr