Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle primitives with same function being applied to same column #321

merged 4 commits into from Nov 16, 2018


Copy link

@kmax12 kmax12 commented Nov 16, 2018

Pandas relies on the function name when calculating aggregations. This means if a two primitives with same function name are applied to the same column, pandas can't differentiate them. We have a work around to this based on the name property that we test here.

Copy link

codecov bot commented Nov 16, 2018

Codecov Report

Merging #321 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
+ Coverage    95.1%   95.11%   +0.01%     
  Files          71       71              
  Lines        7666     7683      +17     
+ Hits         7291     7308      +17     
  Misses        375      375
Impacted Files Coverage Δ
...turetools/computational_backends/ 94.13% <100%> (+0.02%) ⬆️
...ols/tests/feature_function_tests/ 98.66% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e90b63a...42b2bde. Read the comment docs.

@WillKoehrsen WillKoehrsen merged commit 624c653 into master Nov 16, 2018
Copy link

Looks good. Merging.

@rwedge rwedge mentioned this pull request Nov 29, 2018
@kmax12 kmax12 deleted the primitive-naming branch December 1, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants