Remove parse_date_cols parameter from EntitySet._import_from_dataframe #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
==========================================
+ Coverage 95.22% 95.25% +0.02%
==========================================
Files 71 71
Lines 7692 7689 -3
==========================================
- Hits 7325 7324 -1
+ Misses 367 365 -2
Continue to review full report at Codecov.
|
|
Looks good to merge |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keyword argument is in a private method but is never used by other Featuretools methods. All it does is add the columns to
variable_typesas Datetime types, butvariable_typesis already a parameter so they could just be included invariable_typesinstead.